Repository navigation
Check accessible names for theme navigation links - #170
Merged
Merged
Conversation
Signed-off-by: Tim Paine <3105306+timkpaine@users.noreply.github.com>
6 of 11 tasks
Contributor
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #170 +/- ##
==========================================
+ Coverage 89.45% 89.47% +0.01%
==========================================
Files 16 16
Lines 2182 2186 +4
Branches 224 225 +1
==========================================
+ Hits 1952 1956 +4
Misses 160 160
Partials 70 70 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The project-link integration test currently requires Home and Docs labels to be visible text. Check each destination, external-link attributes, and accessible name so both text links and icon buttons satisfy the test. Continue requiring both header and sidebar links.
Companion theme change: python-project-templates/sphinx-fuma#18. This PR changes only test assertions; runtime behavior, dependencies, and version are unchanged.
Validated with
make lint,python -m build, and the fullmake testsuite in a clean temporary checkout: 157 tests pass with the companion Fuma checkout. The updated integration test also passes with released Fuma; all 66 theme tests pass with the icon renderer.Type of Change
Checklist
make lint)make test, clean temporary checkout)