Skip to content

Check accessible names for theme navigation links #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timkpaine merged 1 commit into from
Oct 23, 2026
Merged

Check accessible names for theme navigation links #170

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions yardang/tests/test_themes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import ast
import os
import re
from pathlib import Path
from unittest.mock import patch

Expand Down Expand Up @@ -213,8 +214,11 @@ def test_inferred_urls_render_project_links(self, project, tmp_path):
assert "<title>Test Project" in html
assert 'href="https://github.com/owner/repo"' in html
assert 'href="https://github.com/owner/repo/edit/HEAD/index.md"' in html
assert html.count('href="https://example.com" target="_blank" rel="noopener">Home</a>') == 2
assert html.count('href="https://docs.example.com" target="_blank" rel="noopener">Docs</a>') == 2
for url, title in (("https://example.com", "Home"), ("https://docs.example.com", "Docs")):
links = re.findall(r'<a\b([^>]*href="' + re.escape(url) + r'"[^>]*)>(.*?)</a>', html, re.DOTALL)
assert len(links) == 2
assert all('target="_blank"' in attrs and 'rel="noopener"' in attrs for attrs, _ in links)
assert all(f'aria-label="{title}"' in attrs or text == title for attrs, text in links)


class TestResolveCustomAsset:
Expand Down