Repository navigation
gh-159394: Fix test_curses when $LINES or $COLUMNS is set - #159665
Open
serhiy-storchaka wants to merge 2 commits into
Open
serhiy-storchaka wants to merge 2 commits into
serhiy-storchaka wants to merge 2 commits into
Conversation
The newterm() tests now set the size of the screen explicitly, instead of depending on the environment. Add a test for $LINES and $COLUMNS. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
…term-size # Conflicts: # Lib/test/test_curses.py
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A new pseudo-terminal has no size, so
newterm()takes the size of the screen from theLINESandCOLUMNSenvironment variables, and from the terminfo entry only if they are unset.test_newtermandSLKTests.test_init_reserves_a_linefailed when either variable was set. The newterm tests now set both, so the screen is always 24x80.Also add a test for
LINESandCOLUMNSthemselves.🤖 Generated with Claude Code
test_cursesregression in 3.16.0a1:test_newtermfails on a real terminal that's not 80x25 #159394