Repository navigation
Footer cleanup and piece-level contact links - #7
Merged
Merged
Conversation
Shell pages with the site header no longer show «Back to simoncos.github.io». Articles and shell-backed work pages get a shared piece-contact footer with RSS and follow links from about.contacts and email. Co-authored-by: Che ZHAO <simonzhao1024@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Shell footer — Pages that already include the site header no longer show the redundant «← Back to simoncos.github.io» link. The shared footer keeps copyright, updated date, and RSS links. A
footer_backpage flag remains inrender_footer_blockif a future page needs the back link without the standard header.Piece contact foot — After article and work content, a shared
render_piece_contact_foot()block (inscripts/piece_contact_foot.py) adds RSS plus follow links fromdata/site.jsonabout.contactsandabout.email, in the spirit of godobject’s post footer without copying its styling.Where it applies
build_post_footinarticle_render.pyqingtian.html)src/css/sections/piece-contact.css(bundled intostyles.css)Not in scope
gallery/sharing/, etc.) — still have their own back links where they had them beforeVerification
make generatemake check-all