Repository navigation
fix(control): end manual Charge at restart - #1869
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A manual battery
Chargemust end when Core restarts. Previously FTW savedmode=charge, restored it at boot and resumed full-power charging even while the planner produced a separate plan.Boot now replaces that override with the automatic mode for the saved battery export permission. If planning is disabled, it selects Idle. It saves the replacement and logs the change. Unknown export consent stays unknown; other stored modes keep their behavior. The HA bridge also ignores retained
chargemessages, which could otherwise replay the override on reconnect. Fresh Charge requests still work.The planner already solves on startup. A regression test restores an archived plan and checks that Start creates a new decision using fresh SOC without waiting for the scheduled interval.
Validation:
make verifypassed. The first attempt timed out in the existingTestManagedDriverUpdateRecovery/save; that test then passed three isolated runs, followed by a passing full verify. Docker context and Avahi runtime checks skipped because Docker is unavailable.Stacked on #1789 because it owns the startup/control files and already includes the SOC ceiling fix from #1867. This PR targets
fix/fuse-one-function. No hardware test or site deployment.