Repository navigation
test(site): judge random runs by rig items R2-R7 of the 27 Oct triage #1920
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
66e1caf
test(site): judge random runs by rig items R2-R7 of the 27 Oct triage
frahlg 44e74f3
test(site): tighten the random judge after review of #1920
frahlg 4c48376
test(site): R8 counts a forced battery from when Core has the inverte…
frahlg 8e2719a
test(site): R8 records the seconds Core's timers excuse
frahlg daad277
test(site): only a rise extends a stretch; raises after a step are FTW's
frahlg 90d22d4
Merge branch 'rig-judges-r2-r7' into rig-r8-forced-mode-after-return
frahlg 4985523
test(site): a raise over the fuse on import is FTW's own
frahlg 652df2c
test(site): judge FTW's battery orders as the inverter sees them
frahlg f8e0097
Merge branch 'rig-judges-r2-r7' into rig-r8-forced-mode-after-return
frahlg 0415161
test(site): R8 reads Core's reconnect backoff from source
frahlg 959cae3
test(site): cap a stretch's events by the fuse heat; a car cut into e…
frahlg 55286e3
Merge branch 'rig-judges-r2-r7' into rig-r8-forced-mode-after-return
frahlg 7b2dd98
Merge pull request #1922 from srcfl/rig-r8-forced-mode-after-return
frahlg File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At a current change, this calculation applies the new reading retroactively to the preceding interval. Core's
fuseHeat.stepingo/internal/control/fuse_heat.goinstead integrates its stored previous currents before accepting the new reading. Consequently, the new judge advances heating and cooling transitions by a sample and can change boundary verdicts: starting at 25 A heat, four one-second samples at 25.1 A followed by 24 A produce a four-second judged overload here, whereas Core's model produces three seconds, flipping R5a's three-second criterion. Use the previous sample's phase current for the elapsed interval so the promised Core-equivalent filter has the same timing.Useful? React with 👍 / 👎.