Skip to content

test(site): judge random runs by rig items R2-R7 of the 27 Oct triage - #1920

Merged
frahlg merged 13 commits into
w0-4-rig-scenarios-r1-r5from
rig-judges-r2-r7
Oct 28, 2026
Merged

frahlg merged 13 commits into
w0-4-rig-scenarios-r1-r5from
rig-judges-r2-r7

Conversation

@frahlg

@frahlg frahlg commented Oct 27, 2026 •

Copy link
Copy Markdown
Member

Problem

The nightly random run on master 83c2b24 failed 8 of 10 seeds. The 27 Oct triage (section 4) traced six of the random judge's verdicts to the judge, not to Core, and asked for one new check:

  • R2. A stretch over the fuse took only the windows open at its first sample. An outage or a Core restart that began inside it added nothing. Seeds 207530 (inverter offline at 888.7 s, inside the 884–896 s stretch) and 207539 (ftw:restart 1 s into the 118.7–143.7 s stretch).
  • R3. The battery counted as the 2 s lever while its inverter was offline or had no spare power. Seeds 207530, 207539 (inverter offline) and 207534 (already discharging 3 266 of 5 000 W against a 2.87 A overage).
  • R4. A car that starts on the charger's own 11 040 W default, before FTW's 0 A order lands, counted as FTW's own raise. Seeds 207532, 207534 and 207537.
  • R5. The judge used the instant current. Under the owner rule of 27 Oct, Core lets a phase sit between In and 1.2 × In until its 60 s I² heat passes the line. Seed 207536 (27.84 A on 25 A for 15 s; heat peak 22.4 A).
  • R6. The Charge-now grace ran only from the first ftw:charge_now, and an inverter outage also masked an idle car. Seeds 207534, 207536 and 207539. Seed 207533 failed once test(site): the rig expects the room the fuse rating gives #1908 moved roomA to In.
  • R7. The floor check read the inverter register, not FTW's order, and used the inverter floor + 0.5 %. Seeds 207534 and 207536 (a register left over from an outage, C1), 207531 and 207532.
  • R8. No check that a battery goes back to its own mode after an outage. Per the triage it would have failed 8 of 10 seeds (C1).
  • test(site): rig scenarios R1-R5 and judges at the fuse rating (rig stack #1888, #1907, #1908, #1920, #1922) #1888 review. r3 and r5a measured the instant current against the fuse. Once Core works at In, they must allow what the heat model allows.

Change

All of it is in go/test/site.

  • R2 (judgeInvariants). A window that opens inside a step's stretch extends the stretch's allowance, Core restarts included. The window must open before the stretch ends and while the stretch is still allowed. A window that opens after the allowance has run out excuses nothing. A window inside FTW's own raise does not extend it or turn it into a step.

  • R3. The battery is the lever only if all three hold:

    • its inverter runs (plant running, and no inverter offline or silence window covers the time);
    • its spare power ((5 000 W ± battery W) ÷ 690) covers the stretch's worst overage;
    • for import, it is above the floor the floor check uses (max of the inverter floor and the planner soc_min). At or below that floor it can only charge less.

    Otherwise the lever is the charger, at max(2, command_response_s), plus what is left of any charger outage.

  • R4.

    • A car whose draw rises by more than 1 kW, to more than FTW's last order + 690 W, is a step FTW did not take. The charger is the lever, from the draw start plus max(2, command_response_s) + 5 s.
    • A stretch that no window explains is FTW's own, as on test(site): the rig expects the room the fuse rating gives #1908, in either direction (import or export): it fails 3 s after its clock starts.
  • Faults. Only a meter fault (meter_late) adds its length to a step's time: it blinds FTW. An inverter outage is a step whose lever is the charger. A charger outage (reconnect) delays the charger lever.

  • R5 (heatOver and warm in evaluate_test.go). The judge runs Core's per-phase 60 s I² filter on the plant's currents. A phase between In and 1.2 × In is over only once its heat is over In too. Above 1.2 × In it is over at once. A stretch's clock starts at the first such sample. When the heat delays that start, the step's time runs from there, as Core's cut does.

  • test(site): rig scenarios R1-R5 and judges at the fuse rating (rig stack #1888, #1907, #1908, #1920, #1922) #1888 review. judgeR3 and judgeR5a judge their budgets ("over the fuse no longer than the charger's delay + 7 s" and "over the fuse at most 3 s once under it") with the same heatOver. The instant figure is still recorded.

  • R6.

    • The judge counts idle seconds with room (6 A or more under In, as test(site): the rig expects the room the fuse rating gives #1908 set it) from the moment the room appears.
    • The allowance is evRestartDwell (35 s) + command + startup + one tick (2 s), plus the 2 s for the meter and tick and the 3 s the fuse budgets also give.
    • The count starts again on each Charge now that changes power or phase (read from plan.json). Seconds while Core is down are masked.
    • A cut does not restart the count. A cut FTW had to make stops the car, and the count only starts once the car stops, so it already gets the full allowance. A cut with room is FTW's doing.
    • Only meter and charger faults excuse the car.
  • R7. The floor check counts FTW's own discharge orders below −50 W (status.dispatch) at or below max(inverter floor, planner soc_min). The planner floor is Core's default of 10 % unless the scenario sets it. There is no +0.5 %. The ev-099 tolerance stays until fix(control): one SoC floor for the stale-plan fallback, fuse relief and the hourly import limit #1878 lands.

  • R8 (new criterion "no forced battery mode FTW does not dispatch"). Once the inverter and Core are both up, the inverter may hold a forced charge or discharge (EMS mode 2, command 170/187, over 50 W) that FTW does not dispatch for at most 10 s. It is not tolerated: C1 is open (fix(control): resend the default when an excluded driver returns from an outage #1909, fix(drivers): retry the default on the first good poll after an outage #1915), and the check should stay red until they land.

  • Re-judging saved runs. TestJudge (FTW_SITE_JUDGE) now also judges the random-<seed> runs a results directory holds, from each run's plan.json.

  • Records. result.json gains over_limit_judged (each stretch the clock judged: from, end, clock start, allowed until, step or own), heat_peak_a, car_starts_ftw_did_not_order, charge_now_idle_allowed_s, floor_pct and battery_forced_without_dispatch_s.

Review follow-up (44e74f3)

The review found the first version loosened the judge more than the seeds needed. This commit:

  • makes an unexplained stretch FTW's own again (the first version gave it a step's time). That let an FTW discharge push export to 1.31 × In for 6 s, and a warm fuse sit over In for 600 s split by 1 s dips, pass. ownRise is gone, since it no longer decided anything;
  • stops a window inside FTW's own raise (for example a PV change) from turning it into a step;
  • stops cuts from restarting the Charge now count, so FTW hunting 6 A / 0 A with room no longer hides an idle car. The restart on Core's return was dead code (the down mask already reset the count) and is gone;
  • gives R3 the same floor as R7;
  • limits the extra outage time to meter faults;
  • adds R8.

Second review follow-up (daad277)

The second review found that the R2 growth step chained on events that raised nothing. A car held at 1.25 × In for 278 s with no cut passed, where #1908 failed it. This commit:

  • lets a plain house event (no fault) extend a step's stretch only if the worst phase rose 0.5 A or more within 3 s of it. Load events that change nothing and the inverter's own online no longer extend it. Core restarts, meter faults, outages and car starts extend as before;
  • treats the inverter as back at the end of its outage. Before, the outage window's end was inclusive, so the online instant still had the charger as its lever; now the battery answers in 2 s from there;
  • makes an FTW car raise sent after a window's 2 s meter delay, and before the stretch begins, FTW's own: that window no longer explains the stretch. This covers a raise after an unrelated step and a raise within 60 s of a Core restart;
  • keeps a stretch open across dips under In while any phase's 60 s heat is over In, so a warm fuse held 3 s over and 1 s under fails. A window that opens after the allowance, with no over-In second in between, still gives a new step its own time. That holds after a step or after FTW's own raise that was cut in time; without it the merged stretch would fail a later, separate step;
  • adds tests that pin the export lever, the heat clock for steps and the 60 s restart window. Each of these survived the reviewer's mutation pass.

Third review follow-up (4985523)

The third review found that the judge still credited FTW's own raises to a step in three ways:

  • a car raise sent while a step's import stretch was over the fuse passed as part of the step;
  • a house event that changed nothing, opening as FTW's raise landed, took the rise and gave the stretch a fresh lever time. test(site): the rig expects the room the fuse rating gives #1908 failed this shape;
  • a battery charge raise after a Core restart or after a step's meter delay was not counted (triage C2). The 60 s restart window then excused up to 60 s over the fuse.

For import, a window no longer explains a stretch if FTW did either of these:

  • raised the battery's charge (its order moved more than 100 W toward import) after the window's meter delay and before the stretch;
  • raised the car or the battery while the stretch was over the fuse.

The stretch is then FTW's own. Three limits keep this from blaming FTW for the wrong thing:

  • A raise sent in a dip under the fuse, while the heat keeps the stretch open, is not counted. The owner rule allows a raise when the next step fits under the line. The reviewer's candidate counted any raise in the stretch, so a later raise in a dip turned an earlier, allowed step into a failure.
  • A battery order moved while the inverter is off, or inside an inverter outage, is not counted: it reaches no battery. Without this guard, seeds 207530, 207532 and 207535 flip (the reviewer's finding; 207530 at 889.4 s moved 491 → 2 984 W with the inverter off).
  • Export is unchanged: raising the car into export is the right answer.

Fourth review follow-up (652df2c)

The fourth review found two new false fails in 4985523, one older false fail and one older gap:

  • While Core is down, or before its first tick, status.dispatch is empty. The judge read that as a 0 W order, so a charge order Core sent again on its return counted as a raise from 0. In the shape of 207539 (a restart inside a stretch), a charging battery made the whole stretch FTW's own.
  • A battery move of more than 100 W counted as a raise. Core's closed loop wobbles by more than that: 207539 at 151.7 s goes −4 999, −4 841, −5 000 W while L3 sits at the fuse. One such sample made a step that the battery answered in time FTW's own.
  • The car raise check before a stretch (from daad277) also ran on export. A car raise sent after a PV step soaks up export, yet it made a later export stretch FTW's own. That contradicted the design stated above.
  • On export, nothing checked FTW pushing its battery toward export. A 0 → −5 kW order after a restart, with 21 A on a 16 A fuse for 42 s, passed under the restart's minute.

This commit, following the reviewer's candidate:

  • keeps the last order while status.dispatch is missing, as the inverter does (the reason for R8);
  • counts a battery move from 0.5 A a phase (345 W), the same rise raisedAt uses;
  • checks the car raise before a stretch only on import;
  • on export, makes a stretch FTW's own if the battery order moved 345 W or more toward export after the window's meter delay and before the stretch, or while the stretch was over the fuse. The inverter guard and the dip rule apply as on import.

Owner decisions of 28 Oct 2026 (959cae3)

Fredrik decided two questions this PR left open:

  1. A car cut into export is FTW's own. A car cut FTW sends that pushes export over the fuse counts as FTW's own, as a battery move toward export already did. The stretch gets FTW's 3 s, not the step's charger time. The check runs at the same points as the battery's: after the window's 2 s meter delay and before the stretch, or while the stretch is over the fuse. raisedIn became carMovedIn with a direction, so ownRaise checks car and battery the same way on import and export. A car raise into export still passes.
  2. The heat caps what events add. Between In and 1.2 × In the I² heat model (tau 60 s) judges an overage; above 1.2 × In it fails at once. So the allowance that events add to a stretch (the R2 growth) stops at the heat budget, however many events come. Once a phase's 60 s heat passes In, Core's cut gets its lever's time (lever + 2 s for the meter and tick + 3 s), and no later event extends the stretch past that. Core restarts and outages are capped too. The cap reuses warm()'s heat. Two limits:
    • The cap applies only to what windows add. The windows open at the stretch's first sample keep their full time.
    • A window that opens after the allowance ran out, with the current under the fuse since, is a new step. Its cap runs from it, so a new step after a dip still gets its own time (TestInvariantsAStepAfterADipGetsItsTime). The judge now sorts the windows by time so it can tell the two apart.

This closes E3: small real rises can no longer chain a stretch's allowance.

Tests

  • New unit tests in random_unit_test.go, each built on a seed's or a review case's shape:
    • R2 (207539): a restart 1 s into the stretch passes. Without it, or with a restart after the allowance, the stretch fails.
    • R3 (207534, 207530/207539): with an idle battery the stretch fails at 7 s. A battery already discharging 3 266 W, or an inverter that is not running, gives the charger's 10 s.
    • R4 (207532/207537): a car on the charger's default under a 0 A order is a step. The same draw right after FTW raised the order to 16 A fails as FTW's own.
    • R5 (207536): 27.84 A on 25 A for 15 s passes; 30.1 A fails; 27.84 A held until the heat passes the fuse fails; 25.5 A on a fuse already warm fails.
    • R6: a start after 70 s passes, after 80 s fails; a changed Charge now restarts the count; a cut over the fuse leaves the full allowance; a cut with room, and FTW hunting 6 A / 0 A with room, fail; a Core restart masks its down time; a late meter excuses the car, an inverter outage does not.
    • R7: an FTW order at 5.0 % or at 9 % fails. At 10.5 % it passes. A forced register with no FTW order passes here (R8 judges it).
    • TestInvariantsAStretchWithNoStepIsFTWsOwn: an FTW discharge holding export at 1.31 × In for 6 s, and 25.5 A on 25 A for 600 s with a 1 s dip every 7 s, both fail as own.
    • TestInvariantsAnEventInsideFTWsRaiseLeavesItOwn: FTW's raise to 1.24 × In for 10 s fails with or without a PV event at 51 s.
    • TestInvariantsLeverAndFaults: a step at 8 % SoC gets the charger's time and passes, at 11 % the battery's and fails; a step while the inverter is offline gets the charger's; a 40 s inverter outage no longer covers 15 s over, a 40 s late meter does; a 20 s charger outage delays the charger lever.
    • TestInvariantsNoForcedBatteryWithoutDispatch: a forced register 8 s after the inverter or Core is back passes, 30 s fails; one FTW dispatches passes.
    • TestRecordedRandomFindsSeedRuns.
  • Added after the second review:
    • TestInvariantsOnlyARiseExtendsAStretch: a load event that raises L1 at 50 s extends the stretch; load events every 40 s that change nothing do not (fails at 55 s).
    • TestInvariantsTheInverterIsBackAtItsReturn: the online return changes nothing and the outage's 55 s holds; a rise at the return gets the battery's 2 s.
    • TestInvariantsARaiseAfterAStepIsFTWsOwn: a raise 5 s after a PV change, or 15 s after Core is back, fails; a raise 1 s after the PV change, before the meter shows it, is part of the step.
    • TestInvariantsARestartExplainsAMinute: a stretch 50 s after a restart passes, one 65 s after fails as own.
    • TestInvariantsBatteryLeverForExport: for export, a battery charging 4 kW leaves the charger as the lever; one discharging 4 kW, or idle at its floor, answers in 2 s.
    • TestInvariantsAStepAfterADipGetsItsTime: on a warm fuse a second step after a dip gets its own time, after a step or after FTW's own raise; held too long it fails as a step.
    • Extended: R5 adds 27.84 A held 7 s (passes) and 8 s (fails) after the heat passes the fuse; the R2 test adds a restart 0.2 s after the allowance (fails); TestInvariantsAStretchWithNoStepIsFTWsOwn adds 3 s over and 1 s under a warm fuse; TestInvariantsAnEventInsideFTWsRaiseLeavesItOwn adds a load step that adds 1 A inside the raise.
  • Added after the third review:
    • TestInvariantsARaiseOverTheFuseIsFTWsOwn: a car raise 0 → 16 A at 1.24 × In after a PV step fails, as does a 6 → 10 A raise at 1.25 × In with a load event that changes nothing as it lands, and a battery charge raise 0 → 3 kW at 1.25 × In after a load step. A car and battery raise in a dip under the fuse, with a step after it, passes. So does a car raise into export over the fuse.
    • TestInvariantsABatteryRaiseAfterARestartIsFTWsOwn: a 0 → 4 kW battery order 5 s after Core is back, with L1 at 1.31 × In for 44 s, fails; the same order while the inverter is off passes.
  • Added after the fourth review:
    • TestInvariantsABatteryOrderMovesOnlyWhenFTWMovesIt: a 1 kW order kept, or missing while Core is down and then restored, passes; a 0 W order that comes back as 1 kW after the restart fails. With the battery discharging 4 999 W, a one-sample 158 W wobble passes and a 360 W move fails.
    • TestInvariantsExportIsFTWsOwnOnlyWhenFTWPushedExport: a car raise before an export stretch keeps the step's time. A battery pushed 0 → −5 kW after a restart fails; with the inverter off it passes. A battery moved toward export while the stretch is over the fuse fails; the same move in a dip under the fuse, with a step after it, passes.
    • TestInvariantsARaiseBetweenFuseAndInstantIsOwn: a car raise sent at 1.1 × In is FTW's own (the line is In, not 1.2 × In).
  • Changed tests:
    • TestInvariantsTellStepsFromOwnRaises: with no step the stretch is FTW's own, with or without a recorded raise. It uses 31 A, over 1.2 × In.
    • TestInvariantsJudgeAtTheFuse adds cool-fuse cases, which pass under the heat budget.
    • TestJudgeR3AndR5aAllowTheHeatBudget is new: 27 A on a cool fuse passes past the budget, and 30.5 A fails.
  • Fail before, pass after (third review). On daad277 the three failing car and battery cases of TestInvariantsARaiseOverTheFuseIsFTWsOwn and the running case of TestInvariantsABatteryRaiseAfterARestartIsFTWsOwn pass where they should fail. On the reviewer's candidate diff the dip case fails. With the inverter guard removed, the inverter-off case fails. The reviewer's E1, E2, E6 and E4 tests, the second review's six and the first review's five all pass on this head. The reviewer's E3 (small real rises chain the allowance) still failed on 652df2c; the owner's heat cap (959cae3) closes it.
  • Mutations (third review). The 21 author mutations and the new ones all break at least one test: the import check applied to export, the over-the-fuse terms for car and battery, the inverter-running guard, a 5 kW battery threshold, and the battery-before and car- or battery-inside terms. Two reviewer mutations that survived on daad277, a 3 kW car raise threshold and a 1 s rise window, are now caught.
  • Fail before, pass after (second review). On 44e74f3 these fail: unchanged load events, both inverter-return cases, the raise after PV and after a restart, and 3 s over / 1 s under. The reviewer's six edge tests and the first reviewer's five pass on this head. On the reviewer's candidate diff (plain F3' and inclusive end), TestInvariantsAStepAfterADipGetsItsTime and the rise-at-return case fail, which is why this commit differs from it.
  • Fail before, pass after (first review). On the first version's judge (66e1caf) the review cases fail: hunting cuts and the cut with room (Charge now), export and dips (own), the PV event, 8 % SoC and the 40 s inverter outage (lever and faults), and three R8 cases (no criterion). Earlier, every R2–R7 test failed at base on the case it targets.
  • Mutations (second review). All 21 mutations break at least one test: the export lever, the heat clock for steps, the restart window at 120 s, plain events never or always extending, a 2 A rise threshold, the raise check off or without its meter delay, the inclusive outage end, no stretch across dips, windows only before the allowance, own stretches never or always growing, growth keeping own, the held-sample rule, the floor and running terms of the lever, car starts ignoring the order, the meter-only extra time, a 6 s own budget and the charger outage delay.
  • Mutations (first review). Each of these breaks at least one test: the inverter term and the floor in the lever, the charger outage term, the meter-only extra time, own stretches growing, unexplained stretches as steps, the down mask, the car-start windows, the spare check, and R8's dispatch, inverter and Core masks.
  • Fail before, pass after (fourth review). On 4985523 these fail: the restored order and the 158 W wobble, the car raise before export, the battery export push after a restart and the battery moved toward export over the fuse. The reviewer's five edge tests, the third review's E1, E2, E4 and E6, the second review's six and the first review's five all pass on 652df2c; E3 still failed there (closed in 959cae3).
  • Mutations (fourth review). Each of these breaks at least one test: a missing order read as 0 again, a 100 W or 400 W threshold, no export check, the car check on export again, no before or no in-stretch term on export, the in-stretch term without its over-the-fuse gate, and no inverter guard.
  • Added for the owner decisions of 28 Oct (959cae3):
    • TestInvariantsHeatCapsWhatEventsAdd (E3's shape): 20 A (1.25 × In) on a 16 A fuse after a load step, then a load event every 8 s, each raising L1 0.5 A from a 1 s dip. L1's heat passes In at 62 s, so the cap is 72 s with the 5 s charger. Events that end at 55 s, or at 72 s, pass. Events to 76 s, or chained for 280 s, fail. A Core restart inside the step's time passes a stretch to 55 s and fails one to 74 s, past the heat's cap.
    • TestInvariantsACarCutIntoExportIsFTWsOwn: on a 16 A fuse after a PV step, with the 40 s charger as the lever, a car cut 16 → 0 A while export is over the fuse fails. A cut 16 → 6 A after the meter shows the step and before the stretch fails too. With no cut, with the cut sent before the meter could show the step, or with a raise 6 → 16 A, it passes.
  • Fail before, pass after (959cae3). On 652df2c, the events to 76 s, the 280 s chain and the restart past the cap pass, and so do both cut cases. All four should fail. Every earlier test passes on 959cae3.
  • Mutations (959cae3). Without the new cap for a window after the allowance, TestInvariantsAStepAfterADipGetsItsTime fails. A cap at the heat crossing itself, with no lever time, fails four earlier tests, among them TestInvariantsOnlyARiseExtendsAStretch.
  • go test -race -count=1 ./test/site/... passes, go vet and gofmt are clean, and make verify passes on 652df2c ("vet + test + build clean"; Docker steps skipped). The repo-hygiene scripts (planning docs, telemetry reads at 134 with none added, and both script unit tests) pass against master 7840c33.

The 10 nightly seeds judged again (FTW_SITE_JUDGE on a copy of the 83c2b24 results)

Seed Base (#1908) This PR What fails, and why
207530 fail: outside step (884–896 s) known floor (tolerated): FTW's discharge orders at 7.8–10 %: C7
207531 known (floor) known floor: orders at 5.0 % for 122 s: C7
207532 fail: own raise 32.7–40.7 s fail over the limit: L2 at 21 A on 16 A, 890.7–924.7 s, 4.6 s past the inverter outage's charger time. The car resumed under FTW's standing 10 A offer while L2 carried 11.1 A: C4. Forced battery 145 s: C1. Floor (tolerated): C7
207533 fail: Charge now 38 s fail forced battery 236 s (from 653.7 s): C1
207534 fail: outside step, Charge now fail Charge now: on the 1p Charge now FTW orders 0 A fuse_limit with 6–10 A of room: C6. Forced battery 163 s: C1. Floor (tolerated): C7
207535 pass fail forced battery 234 s (charge, from 579.5 s): C1
207536 fail: outside step, Charge now fail Charge now on the 1p Charge now: C6. Forced battery 272 s: C1. Floor (tolerated): C7
207537 fail: own raise, Charge now, stale meter fail Charge now after the restart: C6. Stale meter: an EV raise at 107.2 s: C5. Forced battery 266 s: C1
207538 pass fail forced battery 230 s, from when the inverter came back (161.4 s on the plant clock): C1
207539 fail: outside step, Home use, Charge now fail Home use estimated for 253 s after the inverter outage (D1). Forced battery 76 s: C1

Times are seconds from the run's start mark. The second review's fixes change no verdict here. Two allowances shrink: 207535's stretch (994.5–1027.5 s) is now allowed until 1074.5 s instead of 1091.6 s, since the inverter's online at 1026.6 s raised nothing; 207539's (118.7–143.7 s) until 179.7 s instead of 187.6 s, since the load drop at 151.9 s raised nothing. No seed has a stretch that runs on across a dip. The third and fourth reviews' fixes change no verdict and no allowance on any seed. Nor do the owner decisions of 28 Oct (959cae3): every seed's metrics are identical to 652df2c's, here and on #1922's merged head. Every remaining failure maps to a Core or driver item: C1 (8 seeds, #1909/#1915), C4 (207532), C5 (207537), C6 (207534, 207536, 207537), D1 (207539), and the tolerated C7. The review fixes did not change any limit, Charge now or floor verdict except 207532, where the inverter outage no longer adds its 52.7 s.

What the judge still cannot see:

  • An FTW raise sent before a step that lands inside the step's charger time (207535 at 1016–1022 s, C4) passes, since the stretch started with the step.
  • On export, a car raise does not make a stretch FTW's own, by design: raising the car is the answer there.
  • Until a phase's heat passes In, events can still chain a stretch over 1.2 × In. The stretch is short then: at 1.25 × In from half load, the heat passes In in about 50 s.
  • A car whose 1p Charge now stalls (C6) for less than the allowance passes. FTW hunting 10 s on and 60 s off with room passes too: the check limits each idle run, not the share of time the car charges.
  • A car that ramps up in 690 W steps on the charger's default is judged FTW's own, since a car start needs a jump of more than 1 kW in one sample. This can only fail too often, never pass wrongly.

Risk

Low. Only tests change, and the PR carries no-changeset. The nightly random run turns red on C1 for most seeds until #1909 and #1915 land; that is the point of R8.

What loosens:

  • A stretch between In and 1.2 × In passes until the heat passes In (owner rule).
  • A window that opens inside a step's stretch extends its allowance.
  • The charger is the lever when the battery cannot answer.
  • A car starting above FTW's order is a step.

What tightens:

  • A plain house event extends a stretch only if the current rose; FTW's raise after a step or a restart is its own; a warm fuse split by dips is one stretch.
  • On import, a car or battery raise sent while the stretch is over the fuse, or a battery charge raise after a step's meter delay or a restart, makes the stretch FTW's own. On export, a battery move toward export at the same points does.
  • The Charge now allowance is shorter, at about 47–112 s instead of 100–170 s.
  • Inverter faults no longer excuse an idle car, and inverter or charger outages no longer add their length to a step's time.
  • The floor is the planner's 10 %, with no +0.5 % (tolerated as ev-099 until fix(control): one SoC floor for the stale-plan fallback, fuse relief and the hourly import limit #1878).
  • R8 is new.
  • A car cut into export over the fuse is FTW's own (owner, 28 Oct).
  • What events add to a stretch stops once the heat passes In, plus Core's lever time (owner, 28 Oct).

Stack and merge order

master ← #1888 (w0-4-rig-scenarios-r1-r5) ← #1907 (e1-rig-judges-at-fuse) ← #1908 (e2-rig-room-at-fuse) ← this PR. Merge it after #1908.

Open PRs on the same files:

No other open PR touches these files.

🤖 Generated with Claude Code

The random judge called eight nightly seeds on master 83c2b24 wrong in
ways the triage traced to the judge, not to Core:

- R2: a stretch over the fuse took only the windows open at its first
  sample. Every window that opens inside it while it is still allowed
  now extends it, a Core restart included (207530, 207539).
- R3: the battery counted as the 2 s lever while its inverter was
  offline or had no spare power. It is the lever only while it runs,
  is above its floor and its spare power covers the overage; otherwise
  the charger, at max(2, command_response_s) (207530, 207534, 207539).
- R4: a car that starts on the charger's own default, or on an order
  still on its way, is a step FTW did not take, answered by the charger
  from draw start + max(2, command_response_s) + 5 s. A stretch is
  FTW's own only after FTW's last change to the car's order was a rise,
  or its battery order moved toward import (207532, 207534, 207537).
- R5 (owner rule): between the fuse and 1.2 x the fuse a phase counts
  only once Core's 60 s I2 heat is over the fuse too; above 1.2 x at
  once (207536). r3 and r5a take the same heat budget (#1888 review).
- R6: idle seconds with room under Charge now are counted from when the
  room appears and may last evRestartDwell + command + startup + a tick
  (+ 2 s meter and tick + 3 s). The count starts again on a Charge now
  that changes the request, on each FTW cut and when Core answers after
  a restart. Only meter and charger faults excuse the car.
- R7: the floor judges FTW's own orders (status.dispatch), not the
  inverter register, against max(inverter floor, planner soc_min) with
  no +0.5 %.

TestJudge now also judges the random seeds a results directory holds,
from each run's plan.json, so a nightly run can be judged again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@frahlg frahlg added the no-changeset PR intentionally exempt from the changeset requirement (dev tooling / non-shipping) label Oct 27, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 27, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-27T18:51:42.369140Z 66e1caf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 66e1caf50f

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread go/test/site/random_test.go Outdated
Comment on lines +493 to +497
over := maxAbsI(r) > fuse
if over && start == nil {
start = r
}
if (!over || i == len(run)-1) && start != nil {
end := r.T
if to, ok := explained(start.T); ok {
if end > to {
unexplained = math.Max(unexplained, end-to)
if firstBad == 0 {
firstBad = to
}
}
} else if end-start.T > 3 {
longestOwn = math.Max(longestOwn, end-start.T)
if firstBad == 0 {
firstBad = start.T + 3
}
if over && from < 0 {
from = i
}
if (!over || i == len(run)-1) && from >= 0 {

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Stop the overload clock when the heat budget covers the current again

If a brief spike above 1.2 × the fuse is followed by a thermally permitted current still above the fuse, clock remains latched and the entire remaining stretch counts as an overload. For example, on a cool 25 A fuse, one second at 31 A followed by 29 seconds at 26 A keeps heat below 19 A, but this judge fails the outside-step criterion after its allowance expires, even though heatOver was true for only one second. End or split the judged interval when heatOver becomes false, as heatRunsOver already does, rather than waiting for instantaneous current to fall below the fuse.

Useful? React with 👍 / 👎.

if i == 0 {
sq[k] = a * a
} else {
sq[k] += (1 - math.Exp(-(r.T-d.samples[i-1].T)/fuseHeatTauS)) * (a*a - sq[k])

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Integrate the previous sample's current into fuse heat

At a current change, this calculation applies the new reading retroactively to the preceding interval. Core's fuseHeat.step in go/internal/control/fuse_heat.go instead integrates its stored previous currents before accepting the new reading. Consequently, the new judge advances heating and cooling transitions by a sample and can change boundary verdicts: starting at 25 A heat, four one-second samples at 25.1 A followed by 24 A produce a four-second judged overload here, whereas Core's model produces three seconds, flipping R5a's three-second criterion. Use the previous sample's phase current for the elapsed interval so the promised Core-equivalent filter has the same timing.

Useful? React with 👍 / 👎.

frahlg and others added 2 commits October 27, 2026 20:14
- A stretch over the fuse that no outside change explains is FTW's own
  again (3 s after the heat clock), in either direction. The guess that
  it was a step let export raises and warm fuses split by short dips
  pass. ownRise is gone: with that rule it decided nothing.
- A window that opens inside FTW's own raise no longer turns it into a
  step; only a step's stretch grows.
- Charge now: a cut no longer restarts the idle count. A cut FTW had
  to make stops the car, and the count starts when the car stops; a cut
  with room is FTW's doing. The restart on Core's return was dead (the
  down mask already resets the count).
- The battery lever uses the floor the floor check uses (max of the
  inverter floor and the planner soc_min). At the floor it can only
  charge less.
- Only a meter fault adds its length to a step's time. An inverter
  outage takes the battery lever away; a charger outage delays the
  charger lever by what is left of it.
- New check (R8, C1): a forced battery mode FTW does not dispatch lasts
  at most 10 s once the inverter and Core are back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…r back

The random judge's R8 check counted 10 s from the inverter's return. The
Modbus reconnect backoff (up to 60 s) holds Core's first good read back,
so the check could not pass even with C1 fixed (207539: 55.7 s).

The count now starts at Core's first good read of the inverter after an
outage or a restart, at the latest 60 s after the return. After an outage
it allows the registry's 30 s default retry (defaultRetryMax) until #1915
(C11) lands. While Core is stopped with SIGTERM, a running inverter must
leave its forced mode within 10 s of the stop: the driver cleanup writes
the default (triage item 10).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Review of #1922. The judge forgives the Modbus reconnect backoff (up
to 60 s) and the registry's default retry (up to 30 s) after a return,
while the triage line is 10 s from the return. result.json now records
those seconds as battery_forced_in_core_timers_s, so a pass such as
207539's (123 s) shows what was forgiven.

TestForcedAllowancesMatchCore reads both timers from Core's source and
fails once the registry retries the default on the first good poll
(#1915, C11) while defaultRetryMaxS is still 30.

Two R8 cases pin the judge's clock: an inverter that is back while Core
is down counts from Core's first read, and a second outage counts from
its own return.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
frahlg and others added 6 commits October 28, 2026 01:55
Second review of #1920:

- A house event that is no fault extends a step's stretch only if the
  worst phase rose 0.5 A or more within 3 s. Load events that change
  nothing and the inverter's own return no longer chain the allowance.
- The inverter is back at the end of its outage, so at its return the
  battery is the 2 s lever, not the charger.
- A window does not explain a stretch if FTW raised the car after the
  window's meter delay and before the stretch: FTW's raise after a step
  or after a Core restart is its own.
- A stretch stays open across dips while a phase's heat is over the
  fuse, so a warm fuse held 3 s over and 1 s under fails. A window that
  opens after the allowance, with no over second in between, still gives
  a new step its own time.
- Tests pin the export lever, the heat clock for steps and the 60 s
  restart window.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Brings in daad277 from #1920 (second review). Both sides added a helper
next to within(); both are kept.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The random judge credited FTW's own raises to a step in three shapes
from the third review of #1920:

- a car raise sent while a step's import stretch was over the fuse
  passed as part of the step;
- a house event that changed nothing, opening as that raise landed,
  took the rise and gave the stretch a fresh lever time;
- a battery charge raise after a Core restart or a step's meter delay
  was never counted (triage C2), so the restart window excused it.

For import, a window no longer explains a stretch when FTW raised the
battery's charge after the window's meter delay and before the stretch,
or raised the car or the battery while the stretch was over the fuse.
A raise in a dip under the fuse still counts as allowed, a battery
order moved while the inverter is off reaches no battery, and raising
the car into export stays the right answer.

The 10 recorded seeds keep every verdict and allowance.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fourth review of #1920 (4985523):

- A missing status.dispatch (Core down, or before its first tick) keeps
  the last order, as the inverter does, instead of reading as 0 W. A
  charge order restored after a restart is no raise.
- A battery move counts from 0.5 A a phase (345 W), as raisedAt does,
  so a one-sample closed-loop wobble is no raise.
- A car raise before a stretch makes it FTW's own only on import.
- On export, a battery order moved toward export after a window's
  meter delay, or while the stretch is over the fuse, makes the
  stretch FTW's own, so a Core restart no longer excuses it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The judge's reconnectBackoffMaxS was a fixed 60 s, checked against
modbus/client.go. #1930 cuts Core's cap to 10 s, so the check would
fail whichever of the two lands second. The judge now reads the cap
from the source the rig builds Core from, and the 207539 shapes are
set relative to it. The unit tests pass with 60 s and with #1930's
10 s applied.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
frahlg and others added 3 commits October 28, 2026 10:15
…xport is FTW's own

Owner decisions of 28 Oct 2026 for the random judge:

- A car cut FTW sends that pushes export over the fuse is FTW's own, as
  a battery move toward export already was: after a step's meter delay
  and before the stretch, or while the stretch is over the fuse.
- What events add to a stretch (R2 growth) stops at the fuse's heat
  budget: once a phase's 60 s heat passes the fuse, Core's cut gets its
  lever's time and no further event extends the stretch. A window that
  opens after the allowance ran out, with the current under the fuse
  since, is a new step and its cap runs from it. This closes E3 (small
  real rises chaining a stretch's allowance).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
test(site): R8 counts a forced battery from when Core has the inverter back
@frahlg
frahlg changed the base branch from e2-rig-room-at-fuse to w0-4-rig-scenarios-r1-r5 October 28, 2026 10:13
@frahlg
frahlg merged commit a00c5a6 into w0-4-rig-scenarios-r1-r5 Oct 28, 2026
frahlg added a commit that referenced this pull request Oct 28, 2026
The judge stack (#1888, #1907, #1908, #1920, #1922) keeps its own
random_test.go; the fuse stack had only copied #1907's change into it.
rig_unit_test.go keeps the judge side and adds the tests only the other
side has (s18 and s8 at the fuse, the planner mode check from #1942).

With #1915 and #1930 on master, R8's allowance for Core's timers shrinks:
defaultRetryMaxS is 0, the backoff is read as 10 s, and an inverter that
returns while Core is down starts its backoff when Core is up again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
frahlg added a commit that referenced this pull request Oct 28, 2026
…ack #1888, #1907, #1908, #1920, #1922) (#1888)

* fix(control): one log of FTW's own EV offers

The battery side read a 20 s pool log of EV offers (State.evOffers), while
the EV fuse limit keeps each charger's offers for its declared response
time, or 180 s when it declares none. After 20 s the battery counted a slow
charger's unshown raise as already in the meter and charged into that room;
when the car started, a 25 A site read 32.6 A per phase for 3 s.

Delete State.evOffers and its two writers. evInMeterW and
clampEVBatteryHeadroom read evShownW, each charger's latest offer less
what it may not show yet. The hourly peak in stepEVMeterLimit takes each
charger's highest offer of the last evSettle from the same log.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): add P0 rig scenarios R1-R5

Stale meter, battery dropout, the planner floor, a SIGKILL restart and
a start into a running site had no judged rig scenario. Add r1-25 to
r5c-25 with their judges and known lines naming the Wave 1 items (A1,
A3/A4, E1, D6). The rig gains stopFTW(sig), a planner soc_min field, a
charger plugged at start and a delayed Core start. r1-25 is skipped
until device-simulator can silence the site meter.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): battery fuse guard reads each phase with its direction

Delete perPhaseOverageW, perPhaseOverageReadingW and perPhaseReliefW.
The battery fuse guard, the fuse saver and the forced discharge read the
signed phase currents (phaseCurrentsA, with #1849's sum check and dead
zone), count the batteries' own move on each phase, and relieve to the
car's working limit, the fuse less max(1 A, safety_margin_a).

Item A5 of the stable plan.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): battery waits only for a declared charger response time

The first A6 change gave the battery side the EV limit's 180 s guess
for every charger that declares no response time. Only Easee Cloud
declares one, so on every other charger the battery reserved the car's
whole demand on top of a reading that already showed the car, and
stopped charging for 3 minutes after each car start or raise. On the
#1868 shape (rig s18) battery charge stayed at 0 W until 180 s.

evShownW now uses the charger's declared power_max_age_s, and evSettle
when it declares none, as master did. Easee Cloud declares 180 s, so the
slow-charger case stays fixed.

Tests: the slow-charger test now declares 180 s, and a new plant test
runs the s18 shape with a fast charger that declares nothing.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): fuse guard reads phases after the hold caps the targets

The guard took the phase relief from the original request, then the 30 s
fuse hold capped that request and the relief came off again. A charge
limited by one phase switched between 1380 W and 0 W on every dispatch.
Predict the aggregate and the phases from the held targets instead.

The phase reader now takes the meter's raw total from OnlineMeterW, the
same reading as its currents, so an offline meter's cached phases drive
no relief. The batteries' raw power is read in one helper. dispatch.go
keeps its 41 cached telemetry reads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): make R2, R4, R5a and R5b judge what Core does on master

Review fixes for W0-4:

- r4: Core refuses a battery hold over 1800 s, so the 3600 s hold made
  the run error before any kill. Post a 1800 s hold 300 s before the
  first kill; it outlasts both.
- r2: the site stays under 1.2 x the fuse, where Core cuts the car on
  its documented 60 s heat budget (control/fuse_heat.go), not at once.
  Judge that contract: over 1.2 x the fuse at most the charger's delay
  + 7 s, and the 60 s heat under 1.13 x the fuse. Record the time over
  fuse - 1 A and when Core sends the cut.
- r5a: start the battery at its 5 % floor so the site runs 30 A before
  Core starts, check that as setup, and judge against fuse - 0.5 A,
  Core's own line (as r3 does).
- r5b: drop the D6 known line. The saved plan is younger than
  MaxPlanAge and a fresh plan lands within seconds, so the deadline
  reserve never acts and the run does not reach D6.
- r1, r4: Charge now counts as back only once it runs unbroken to the
  next event, so a stop that starts after the restart is seen.
- README: move the r rows off the s17 line #1875 edits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): judge R2-R5a at the fuse rating, not fuse - 0.5 A or - 1 A

Core's working limit is the fuse rating less safety_margin_a, which is
opt-in (owner rule of 27 Oct). R3 and R5a now judge the overage above
the fuse, R2 and R4 record it there, and the fixtures put Core's own
line at 25.0 A on a 25 A fuse. New cases hold exactly 25.0 A (passes)
and 25.1 A beyond the time budget (fails) for R3 and R5a.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): pin R5a's 3 s clock to the first sample at the fuse

R5a's second criterion now starts its clock at the first sample at or
under the fuse, not under fuse - 0.5 A. So a site that dips to 24.8 A
and then holds 26 A for 10 s fails, where the old judge passed. Add that
case so the clock start cannot drift back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): the rig's "over the limit" is above the fuse, not fuse - 1 A

Core's working limit per phase is the fuse rating less safety_margin_a,
and the margin is opt-in (owner rule of 27 Oct). The invariants judge,
the overage helper behind S9-S11, S3, S8 and S15bat now count a phase as
over the limit only above the fuse rating. The fuse - 1 A and
fuse - 0.5 A metrics go; the I2 and back-under metrics read at the fuse.
Time budgets stay as they were.

This only loosens the judges, so Core that still holds In - 1 A passes.
Room expectations (S1, S12, the random roomA) stay at fuse - 1 A for now.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): the rig expects the room the fuse rating gives

S1 targets floor(fuse - house) in 1 A steps (8 970 W on 16 A with a 3 A
house, was 8 280 W). S12 counts a cut on room alone while every phase is
under fuse - 0.1 A and records fuse_limit with 6 A of room under the fuse.
The random judge measures Charge now room against the fuse, with the
car's 6 A minimum as the threshold. The stack pins safety_margin_a to 0
so the rig does not depend on Core's default.

This tightens the rig: it passes only once Core works to the rating.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): say S1-16's target is a floor while the battery covers the house

A run on a Core that stops at fuse - 1 A gave the car 9 590 W with the
battery at -5 000 W, above the 8 970 W target. S1-16 does not catch the
old line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): car and battery-beside-car work to the fuse rating less safety_margin_a

The EV phase limit was In - 1 A, fixed in code. It is now fuseLineA():
In - safety_margin_a, with no floor. A rise moves one step once it fits
under the line, a start takes all the room, and battery charge beside a
car uses the same line. The hour's import limit keeps its own margins.
Starts and per-phase cuts round down to whole charger amps, since
chargers round offers to the nearest amp.

Step 3 (PR b) of the fuse-at-rating plan (owner rule of 27 Oct).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): keep covered offers whole and leave battery relief out of EV room

Two review findings on the fuse-line change:

- A cut rounds to whole charger amps only when a new cut is needed. When
  cuts on their way cover the overage, the offer stays as it is. Rounding
  a kept step-table offer took the car 6200 -> 5500 -> 4800 -> 0 W in 3 s
  on a 0.6 A overage while a 180 s cut travelled.
- Dispatch records the discharge the fuse guard adds to each battery, and
  an EV rise or start does not count it as room. Before, the car rose into
  the relief and the battery fed it 650 W at the line for as long as the
  house load stayed.

The noisy-line sim test now pins the slow one-step cycle at an exact fit
(at most 5 cuts an hour, never a stop) and no moves with part of a step
left, instead of allowing 45 moves an hour.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): battery fuse guard reads each phase with its direction

Delete perPhaseOverageW, perPhaseOverageReadingW and perPhaseReliefW.
The battery fuse guard, the fuse saver and the forced discharge read the
signed phase currents (phaseCurrentsA, with #1849's sum check and dead
zone), count the batteries' own move on each phase, and relieve to the
car's working limit, the fuse less max(1 A, safety_margin_a).

Item A5 of the stable plan.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): fuse guard reads phases after the hold caps the targets

The guard took the phase relief from the original request, then the 30 s
fuse hold capped that request and the relief came off again. A charge
limited by one phase switched between 1380 W and 0 W on every dispatch.
Predict the aggregate and the phases from the held targets instead.

The phase reader now takes the meter's raw total from OnlineMeterW, the
same reading as its currents, so an offline meter's cached phases drive
no relief. The batteries' raw power is read in one helper. dispatch.go
keeps its 41 cached telemetry reads.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): battery relieves to the fuse less safety_margin_a

phaseFuseReliefW now reads fuseLineA(), the line the car uses since the
EV change, instead of max(1 A, safety_margin_a). There is no floor under
the margin: at margin 0 the battery works to the fuse rating.

Tests return to the rating where they had moved to the 1 A limit, and a
new property test covers In x phases x margin in both directions.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(control): re-record golden records at the fuse less safety_margin_a

Replayed from stored inputs; only records whose dispatch changed against
the parent branch were replaced.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): battery fuse cut lands on the line, not half a margin below

applyFuseGuard cut a battery charge or discharge by the overage plus
half of safety_margin_a. The guard now predicts from the held targets
and keeps its 30 s hold, so the extra cut only parked the phase below
the line the user set. Cut by the overage only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(changeset): name the limit the battery cut lands on

The changeset said the phase lands on the fuse less safety_margin_a.
On #1891 as it stands, the phase line is the fuse less max(1 A,
safety_margin_a), so at the 0.5 A default a 16 A phase settles at
15 A, not 15.5 A. Say what this PR changes, cutting only by the
overage, without naming a line that depends on step 4.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(config): fuse safety_margin_a defaults to 0

Core now works to the fuse rating unless a site sets a margin. Every
explicit safety_margin_a is kept. A stored value of exactly 0.5 A, the
old default, adds one load-time notice and changes nothing.

The peak-limit error names the margin only when it is above 0, and the
settings field shows 0 with help that says the margin is opt-in.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(changeset): say what the default change moves on its own

The changeset said FTW works to the fuse rating unless a site sets a
margin. On this PR's base every per-phase line still sits 1 A under the
rating; that holds only once #1910 and the step-4 amendment of #1891
land. The changeset now names what this PR changes: the default, and
the whole-site import and export limits.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(control): relief stays at the line after a PV drop (C3, seed 207533)

On a 16 A fuse with no margin the battery holds 3 kW of discharge with L1
at 14.4 A; PV drops 1280 W and L1 reads 16.3 A. The relief must bring L1
to 16 A and keep it there while the reading sits at the line with the
battery at its relief power. Without phaseFuseReliefW's own-move count
the relief flips between -3214 W and -3005 W on every tick and L1 crosses
the rating 13 times; with it, L1 crosses once.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): judge random runs by rig items R2-R7 of the 27 Oct triage

The random judge called eight nightly seeds on master 83c2b24 wrong in
ways the triage traced to the judge, not to Core:

- R2: a stretch over the fuse took only the windows open at its first
  sample. Every window that opens inside it while it is still allowed
  now extends it, a Core restart included (207530, 207539).
- R3: the battery counted as the 2 s lever while its inverter was
  offline or had no spare power. It is the lever only while it runs,
  is above its floor and its spare power covers the overage; otherwise
  the charger, at max(2, command_response_s) (207530, 207534, 207539).
- R4: a car that starts on the charger's own default, or on an order
  still on its way, is a step FTW did not take, answered by the charger
  from draw start + max(2, command_response_s) + 5 s. A stretch is
  FTW's own only after FTW's last change to the car's order was a rise,
  or its battery order moved toward import (207532, 207534, 207537).
- R5 (owner rule): between the fuse and 1.2 x the fuse a phase counts
  only once Core's 60 s I2 heat is over the fuse too; above 1.2 x at
  once (207536). r3 and r5a take the same heat budget (#1888 review).
- R6: idle seconds with room under Charge now are counted from when the
  room appears and may last evRestartDwell + command + startup + a tick
  (+ 2 s meter and tick + 3 s). The count starts again on a Charge now
  that changes the request, on each FTW cut and when Core answers after
  a restart. Only meter and charger faults excuse the car.
- R7: the floor judges FTW's own orders (status.dispatch), not the
  inverter register, against max(inverter floor, planner soc_min) with
  no +0.5 %.

TestJudge now also judges the random seeds a results directory holds,
from each run's plan.json, so a nightly run can be judged again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): tighten the random judge after review of #1920

- A stretch over the fuse that no outside change explains is FTW's own
  again (3 s after the heat clock), in either direction. The guess that
  it was a step let export raises and warm fuses split by short dips
  pass. ownRise is gone: with that rule it decided nothing.
- A window that opens inside FTW's own raise no longer turns it into a
  step; only a step's stretch grows.
- Charge now: a cut no longer restarts the idle count. A cut FTW had
  to make stops the car, and the count starts when the car stops; a cut
  with room is FTW's doing. The restart on Core's return was dead (the
  down mask already resets the count).
- The battery lever uses the floor the floor check uses (max of the
  inverter floor and the planner soc_min). At the floor it can only
  charge less.
- Only a meter fault adds its length to a step's time. An inverter
  outage takes the battery lever away; a charger outage delays the
  charger lever by what is left of it.
- New check (R8, C1): a forced battery mode FTW does not dispatch lasts
  at most 10 s once the inverter and Core are back.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(control): phase relief reads each battery live, in the decision's reading

The merge of #1876 moved stopPhaseReliefW's live reads into
phaseSample.moveW. Pin it: a battery that went offline, moved on to a
newer reading or has no reading gives no phase relief. With the cached
RawW read #1891 had, the offline and newer-reading cases relieve 2310 W
and the no-reading case counts a 2000 W charge from 0 W.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): battery relief holds when the battery's reading lags the meter

The phase relief counts the battery's move from its own reading. When
that reading lags the meter by a tick, the meter already shows the relief
while the reading does not, so the relief came off; on the next tick it
went back on top of the reading's catch-up. In the 207533 shape (16 A,
margin 0) with a one-tick lag the order ran -3214, -3005, -3422, -3005,
... -5717 W and L1 went back to 16.3 A on every other tick: 13 crossings.

A move from the battery's last command (the one it got in the last
dispatch) may now not pass the room the meter shows either. That bound
only tightens, and a phase already over the line gives it no room, so it
never asks for more than to stay at the last command: a battery that
falls short of its order does not wind it up. With lag 1 or 2 the order
holds -3214 W with L1 at 16.0 A and one crossing, on the PV step.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): R8 counts a forced battery from when Core has the inverter back

The random judge's R8 check counted 10 s from the inverter's return. The
Modbus reconnect backoff (up to 60 s) holds Core's first good read back,
so the check could not pass even with C1 fixed (207539: 55.7 s).

The count now starts at Core's first good read of the inverter after an
outage or a restart, at the latest 60 s after the return. After an outage
it allows the registry's 30 s default retry (defaultRetryMax) until #1915
(C11) lands. While Core is stopped with SIGTERM, a running inverter must
leave its forced mode within 10 s of the stop: the driver cleanup writes
the default (triage item 10).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): R8 records the seconds Core's timers excuse

Review of #1922. The judge forgives the Modbus reconnect backoff (up
to 60 s) and the registry's default retry (up to 30 s) after a return,
while the triage line is 10 s from the return. result.json now records
those seconds as battery_forced_in_core_timers_s, so a pass such as
207539's (123 s) shows what was forgiven.

TestForcedAllowancesMatchCore reads both timers from Core's source and
fails once the registry retries the default on the first good poll
(#1915, C11) while defaultRetryMaxS is still 30.

Two R8 cases pin the judge's clock: an inverter that is back while Core
is down counts from Core's first read, and a second outage counts from
its own return.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): a landed EV cut covers nothing later; a raise that no longer fits comes off

The site meter now tells Core how much of a charger's offers it already
shows. A move shaped like an order landing (every phase alike, or one
phase alone for a one-phase car) moves that level toward the latest
offer. A cut the meter shows no longer covers an overage that an outside
step causes after it, and no longer nets against a raise sent after it.
Where a landing and a house step fall in one reading, a cut covers a
phase that has risen since only up to the overage it had then.

C4: our own rise on its way, as the meter tells it, is judged as the
reading it will make. Above 1.2 x In, or over the line on a phase whose
heat budget is spent, it comes off on this reading, down to the line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): a one-phase house move is not the car's cut landing

seeOffers kept one shown level for every phase, so a house load moving on
one phase alone read as a three-phase cut landing and took the cut's cover
off the phase it was sent for. With a 40 s charger Core then stacked a
second cut and left L1 2 A under the line for over 2 min. The shown level
is now kept per phase: a three-phase order moves every phase alike, and a
phase that moves alone moves only its own level.

The loadpoint now reports a car it has seen draw on all three phases as
CarPhases 3. For such a car a one-phase move is never the car, so a house
step on one phase while a raise travels no longer hides the raise, and C4
cuts on that reading.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): a battery charge rise fits each phase before it is sent

The battery fuse guard judged a rise from the battery's own reading and
the meter's phases, so it took a rise the meter did not show yet as
already shown. With the meter a poll behind the battery, a PV surplus that
grew each tick stacked rises past the line, then the relief cut them back:
16.4 A on a 16 A fuse and a charge that rose and fell (C2, seeds 207530,
207535).

fitBatteryRisesToFuse caps charge above the battery's latest order to
(fuseLineA - worst phase - own unshown rises) x V x phases. The unshown
rises are the battery's orders of the last evSettle and the chargers'
raises, counted as evShownW counts them, so the car comes first. Holding
an order is never a rise and the check never cuts; an overage stays with
the relief. No margin and no floor: the order ends at the line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): battery rise check counts slow batteries and direction-less phases

A battery order now stays unshown until evSettle after the battery's own
reading reaches it, so a battery that ramps slower than evSettle no longer
gets a second rise on top of an order the meter cannot show yet.

On a meter with phase currents but no phase power while the total
exports, a phase counts as export only when the other phases cannot
carry the export alone; any other phase counts as import. Before, every
phase flipped to export, so a three-phase charge could rise into a phase
that imports beside two exporting ones.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): the car comes before battery charge

With battery_covers_ev off, dispatch took the car out of the meter
reading before the battery decided. The battery then saw the PV the
car was using as export and charged from it while the site imported
for the car (rig seeds 207535, 207539, 207530: about 10 kW import).

The battery now charges only from the surplus the meter shows after
the car. Where the house alone has surplus, the battery sees the meter
with the car included, and any discharge stops at once, since it would
feed the car. A planned PV charge on the energy path takes only the
surplus the car leaves; a planned grid purchase keeps its charge.
Cover off still never discharges the battery for the car.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): peak shaving drops a running charge for the car

Manual peak_shaving gave zero error for any import under the peak
limit, so a battery charge that was running when the car started held
while the site imported for the car, with battery_covers_ev on or off.
When the site imports while the car and the battery both charge, the
charge now comes down by the import, to 0 at most. Under the peak limit
the battery still never discharges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): after a restart the battery credits the car the meter shows

After a restart, the 0 A orders FTW sent while the meter was stale counted
as the EV base the meter shows. With the car still drawing 8.2 kW from
before, a new 6.2 kW order then counted as a 9 A rise to come, and the
battery was held in discharge for the car (seed 207532).

Until a charger's first order of this run can have landed, the battery
side now counts the charger's live measured draw as in the reading, never
above the latest order and never above the consumption the site meter
shows. The car's own limit does not read it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): credit a found car only from a current charger sample

Review of #1926 found two ways the restart credit let the battery end a
discharge into room the car's pending rise still needs:

- The charger reading counted with no check that it was current. A held
  reading after a failed poll, or a sample older than the site reading,
  could show a car that a fast charger had already stopped. The draw now
  counts only when the last poll succeeded and the charger measured it
  within one control interval of the site reading.
- The consumption bound subtracted the smoothed battery, PV and V2X
  values, which lag an output that just fell. It now takes the higher of
  raw and smoothed for each, so the bound stays at or below what the
  meter shows.

New tests pin both, plus the shown-offer subtractions and a window that
outlasts evSettle.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(control): run the site sim at the new 0 A default margin

simFuseSafetyA follows the config default, now 0. fitScenario takes the
room under the line and sets the house from simFuseSafetyA, so its exact
fit stays twelve whole steps at any margin. "charger's own load
balancer" passes at margin 0, so its known line goes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(changeset): say what margin 0 moves once the fuse stack lands

With the stack under it, the default moves the car's and the battery's
per-phase line as well as the site totals. 0.5 A stops being the
default, so #1910's changeset no longer calls it that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(control): keep the load-balancer bug as a known line above the line

At the 0 A default the scenario passes only because the charger's own
balancer sits at 25 A, the rating and so the line. The bug is still in
Core: a cut comes off an offer the car does not draw. Two known variants
keep it tracked and turn red once it is fixed: the stored 0.5 A margin
(over 24.5 A for more than 11 s) and a balancer at 25.5 A at margin 0
(over 25 A for more than 11 s).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): EV room reads battery relief through live telemetry

evFuseReliefW read each battery's cached RawW, which survives a driver
going offline. It now reads Store.OnlineRawW. A battery with no live
reading counts its whole recorded relief, so the car never builds on
discharge Core can no longer hold.

fuseSaverEarlyExit read each battery's SmoothedW a second time to record
relief. It now records against the live snapshot the fuse-saver decision
already took (fleetAtLivePower), so it adds no read of its own.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): only a rise extends a stretch; raises after a step are FTW's

Second review of #1920:

- A house event that is no fault extends a step's stretch only if the
  worst phase rose 0.5 A or more within 3 s. Load events that change
  nothing and the inverter's own return no longer chain the allowance.
- The inverter is back at the end of its outage, so at its return the
  battery is the 2 s lever, not the charger.
- A window does not explain a stretch if FTW raised the car after the
  window's meter delay and before the stretch: FTW's raise after a step
  or after a Core restart is its own.
- A stretch stays open across dips while a phase's heat is over the
  fuse, so a warm fuse held 3 s over and 1 s under fails. A window that
  opens after the allowance, with no over second in between, still gives
  a new step its own time.
- Tests pin the export lever, the heat clock for steps and the 60 s
  restart window.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): a raise over the fuse on import is FTW's own

The random judge credited FTW's own raises to a step in three shapes
from the third review of #1920:

- a car raise sent while a step's import stretch was over the fuse
  passed as part of the step;
- a house event that changed nothing, opening as that raise landed,
  took the rise and gave the stretch a fresh lever time;
- a battery charge raise after a Core restart or a step's meter delay
  was never counted (triage C2), so the restart window excused it.

For import, a window no longer explains a stretch when FTW raised the
battery's charge after the window's meter delay and before the stretch,
or raised the car or the battery while the stretch was over the fuse.
A raise in a dip under the fuse still counts as allowed, a battery
order moved while the inverter is off reaches no battery, and raising
the car into export stays the right answer.

The 10 recorded seeds keep every verdict and allowance.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): an offline battery's fuse relief ends after evSettle

With no battery online, ComputeDispatch returns before it records relief,
so batteryFuseRelief kept its last value and evFuseReliefW counted all of
it for as long as the battery stayed offline. The car was held up to the
whole relief below the line. The relief now counts in full until the
default mode Core sent at the transition can have reached the meter
(evSettle), then ends.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): judge FTW's battery orders as the inverter sees them

Fourth review of #1920 (4985523):

- A missing status.dispatch (Core down, or before its first tick) keeps
  the last order, as the inverter does, instead of reading as 0 W. A
  charge order restored after a restart is no raise.
- A battery move counts from 0.5 A a phase (345 W), as raisedAt does,
  so a one-sample closed-loop wobble is no raise.
- A car raise before a stretch makes it FTW's own only on import.
- On export, a battery order moved toward export after a window's
  meter delay, or while the stretch is over the fuse, makes the
  stretch FTW's own, so a Core restart no longer excuses it.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): each offline battery's fuse relief ends after evSettle

The expiry in 8150b45 ran only when no battery was online. With a
second battery online, an offline battery's relief stayed until a
recorded dispatch rewrote the map: never while the legacy modes sat in
the deadband, and on the first tick when one did record, so the car
could rise onto discharge Core ordered a second earlier. Each offline
battery now has its own clock: its relief counts whole for evSettle
and then ends, on every dispatch path. A battery back online leaves the
clock, so its next offline period counts whole again; a test now covers
that reset.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): battery phase relief neither pins mixed phases nor winds up

The last-command bound held the battery at its last command when one
phase sat at the import line and another was over the export line: the
guard cut the discharge for the exporting phase and the bound put it
back. Now the bound gives way on one side while any phase is over the
other side's line, and phaseFuseReliefW's least-over move decides.

When the meter does not show the battery's move (a frozen meter, or a
worst phase a one-phase battery cannot reach), each tick added the same
overage again and the order ran out to the discharge limit. Now the
relief toward the worst phase stops at the last command once the
batteries' raw power has moved one ampere per phase since the worst
phase last moved by half an ampere. One ampere is the step in which P1
meters report phase current.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): battery phase anti-windup stops only when the meter cannot show the move

phaseUnresponsive stopped the relief whenever the batteries had moved
690 W and the worst phase had not moved half an ampere. On a live meter
that also happens when a load cancels the move (a balanced load starting
with the relief step, or a slow rise on the worst phase), and when the
battery's reading catches up with an order the meter already showed.
The relief then held over the line with no end.

Now it stops only when the meter repeats its phases exactly while the
batteries moved one ampere per phase, or when another phase moved by
twice the balanced share of that move (a battery off the worst phase).
The repeat is measured from the reading the meter last changed in, so a
meter that freezes on any reading is still caught.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): battery off the worst phase goes back, and a stale reference ends

Fourth review of the phase anti-windup (c066892):

- The worst phase's reference had no end while that phase sat over the
  line. A relief that follows a slow drift keeps it there, so the
  reference stayed while the battery moved hundreds of watts, and a load
  that later switched off on another phase read as a battery off the
  worst phase. The relief then held L1 up to 0.49 A over the line with no
  time limit. The reference now also ends when the worst phase is at or
  inside the line, or when another phase becomes the worst.
- An off-phase verdict no longer holds the last command. The batteries go
  back to their power when the worst phase last moved: what they moved
  since did not reach it. A one-phase battery no longer holds its own
  phase at -17.97 A for the whole overage (and -19.83 A, past 1.2 x In,
  when PV returns). A false verdict on a balanced battery moves the
  worst phase by at least one ampere on the next reading, which ends the
  reference, so it costs one tick instead of an open-ended hold. The
  verdict holds until the reference ends, so the relief does not go out
  again once the battery is back.
- The frozen-meter test now also compares the meter's total. A P1 meter
  reports whole amperes, so a live meter can repeat its phases while its
  total moves; that latched the relief at 1.11 x In.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(control): the drift test also wants no verdict on the load change

With L1 at the line ending the reference, no off-phase verdict comes when
the load on L3 switches off. Without it, the step back still ends the
hold, but with L1 at 16.8 and 17.7 A for two ticks; the test now sees
that.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(control): our battery order's move is not the car's cut landing

The guard in seeOffers that stops reading the meter while our battery
order moves had no test; removing it left every test green. A battery
order that lands and goes back while a cut travels to a 40 s charger
now must not lead to a second cut.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(control): the car-first discharge stop has its own test

Removing the PI path's immediate discharge stop left every named test
green; only the golden replay caught it. A peak_shaving loop with
battery_covers_ev off, starting from a 2.9 kW discharge while the house
alone has surplus, now requires that no order discharges into the car.

The comment on the plan back-off said the plan's grid leaves out the car.
It counts the car it planned; the comment now says so.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): the battery rise check reads only live battery power

fitBatteryRisesToFuse, unshownBatteryW and recordBatteryReadings read
the battery's cached RawW, which survives the driver going offline, and
added three direct telemetry reads that the repo-hygiene check refuses.
They now use Store.OnlineRawW, as phaseSample.moveW does: an offline
battery's last value no longer sets the rise base or the shown level.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): judge a raise's landing from the meter's rise

C4 counted a raise as landed only when a reading-to-reading move had a
charger's shape. A slow ramp, or a house load on another phase that moved
in the landing reading, left the whole raise counted as on its way on top
of a reading that already held it, and Core cut a raise that fit under
the line. The rise still to come now reads the meter's own rise since the
raise went out: the smallest across the phases for a three-phase order,
the car's phase for a one-phase car.

For a three-phase order, a move on one phase alone no longer moves the
shown level of a car not yet seen. A load cycling on the phase over the
line took the cut's cover off on each drop and never gave it back, so
Core cut again and again.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): a car not yet seen may take a raise on one phase

The smallest rise across the phases read a one-phase car not yet seen
as a raise that had not landed: its phase rose, the other two did not.
Core then cut the car from 11040 W to 0 with every phase under the line
(field matrix, car1p cases). One phase that has risen alone since the
raise went out, the others within half a step, now counts as that car
taking the raise, as the shape tracker read it before. The changeset
again says what holds: the one-phase house step case is closed for a
car seen on three phases.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): judge a one-phase landing reading by reading

For a car not yet seen on three phases, a raise counted as landed on one
phase only while the other phases stayed within 0.5 A of their reading
when the raise went out. That window spans the charger's whole response
time, so 0.6 A of house drift on another phase made the full raise count
as still to come on top of a reading that already showed it, and Core
cut the car with every phase under the line (field matrix with 0.7 A on
L2: car1p cut 11100 -> 0 W).

Each phase now keeps its rise over the readings in which the other
phases moved less than a step (aloneA). A rise of a step or more there
may be the car on that phase. Drift between readings, or under a step
in the landing reading, no longer hides it; a house load that moves a
step or more on another phase in the same reading still does.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): restart credit keeps room for the car's rise to its max

After a restart Core does not know the offer in force on the charger, so
a car drawing below it may still rise before Core's order lands. The
credit now counts only the draw less that possible rise past the latest
offer, with the rise measured to the loadpoint's max_charge_w; a charger
with no max_charge_w gets no credit.

The charger and output reads move into health-gated telemetry accessors
(OnlineLowerW, SumOnlineHigherW). Tests cover the raw and smoothed
guards, a 10 s OCPP sample cadence on the plant, and the review's car
rising under a 16 A offer in force.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(control): Charge now landing shown before Core logs its offer

Site rig s1-16, s1-25 and s15-25 failed on c9b52c3: the charger answered
within a second, and the meter reading that showed the car at 15.9 A came
in 7 ms before the tick that first logged the 16 A offer. The reading
could not show an offer logged after it, so the landing counted as a
raise still to come, 15.9 + 16 A passed 1.2 x In, and Core cut 11,040 W
to 5,520 W with 9 A of room on every phase. The same run of the base at
281f9f6, without this branch's commits, fails the same way; #1923's
ab02710, merged here in c0a5274, reads the meter's own rise and fixes
it. This test pins that rig shape.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): restart credit counts no sample newer than the meter

The battery side's restart credit (evFoundDrawW) had two gaps.

A charger sample measured after the site reading counted as part of
it. A car that rose in that gap was credited for draw the meter did
not show yet, and the battery ended its discharge into room the rise
had taken. With a 3 s meter, L2 reached 19.30 A. A sample now counts
only when measured at or before the site reading.

The rise reserve took max_charge_w as the most the unknown offer in
force can be. A charger still on an offer from before a restart that
lowered max_charge_w, or on its own higher default, could rise past
it: 19.00 A per phase on the unit fixture, 19.30 A on the plant. The
reserve now runs to the larger of max_charge_w and the site fuse's
rating.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): restart credit holds against a charger clock behind Core's

The restart credit compared a charger's sample time, stamped by the
charger's own clock (OCPP MeterValues), with the time the site reading
arrived on Core's clock. A charger clock 1 s or more behind Core's let
a rise sampled after the reading count as already in it, and L2 reached
19.30 A on the third review's plant case.

A sample now counts only when stamped evClockAllowance (5 s) before the
reading arrived, and the draw is the lowest of that sample and every
sample since. noteDraw keeps the charger's samples while the restart
window is open.

Also tests the max_charge_w half of the rise cap: a 22 kW charger on a
3 x 25 A fuse keeps the reserve up to max_charge_w.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* docs(control): the fuse margin is opt-in, and only the fuse ceilings move

The SiteFuseSafetyA comment read as if the margin were needed by
default; it now says zero is the default and when to set one. The
changeset named "the site's total import and export limits", which
reads as the hourly import_limit; that limit does not move. It now
names the fuse's import and export ceilings.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(control): battery beside a minimum-step car holds the fuse line (rig s18-16)

On #1910 and #1891 the battery rises beside the car to the working limit,
the fuse guard cuts it by the overage plus half of safety_margin_a and holds
30 s, and the battery rises again: it hunts between 15.0 and 15.5 A on a
16 A site. Where it stands when the house moves is chance, which is why
rig s18-16 failed 3 of 57 runs on those heads. #1913's cut by the overage
only keeps it on the line.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(config): an unset fuse margin reaches Core as 0

A mutation that restored a hidden 0.5 A margin at startup passed every
suite. This test pins the value newControlStateFromConfig hands Core.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): s18 judges own commands apart from the house's step

At margin 0 Core holds the phases at the 16 A line. Rig s18-16's 0.1 A
house step at small_step then lands over the line until Core cuts: on
fdfbfec the phase read 16.101 A for 3 s and Core cut the battery
4851 -> 4719 W within 2 s. The criterion "own commands stay inside the
rated fuse" counted that stretch as Core's and failed. The owner's rule
judges an overage between In and 1.2 x In by the I2t model.

The criterion now skips the 10 s after the step, the same gap the minor
window already leaves. On the fdfbfec record Core's own commands peak
at 16.008 A before the step and 16.005 A after it, inside 16.01 A.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): R8 reads Core's reconnect backoff from source

The judge's reconnectBackoffMaxS was a fixed 60 s, checked against
modbus/client.go. #1930 cuts Core's cap to 10 s, so the check would
fail whichever of the two lands second. The judge now reads the cap
from the source the rig builds Core from, and the 207539 shapes are
set relative to it. The unit tests pass with 60 s and with #1930's
10 s applied.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): no cut of an unseen car, no landing from a 1p house move

Two regressions against #1913 from the final review.

A car the loadpoint has not seen on three phases may draw on one phase
Core does not know. The alone rise (aloneA) missed its landing when any
other phase moved a step in the same reading, so the whole raise counted
as still to come and C4 cut a car with every phase under the line, at
most session starts with a 10 s meter. riseAheadA now takes the largest
rise for such a car, as for a one-phase car whose phase is not known,
and the smallest only once the car is seen on three phases.

A one-phase order never knows the car's phase, so a house load moving
alone on any phase read as its cut landing and took the cover off a cut
still on its way. A one-phase move now counts only on a known car phase.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix(control): judge a restart sample by its arrival, not its stamp

The 5 s clock allowance let the restart credit count a charger sample
taken 5-7 s before the site reading. A car that stopped after that
sample (a fast charger applying the 0 A sent while the meter was stale,
or the car pausing) still counted, the battery ended the discharge the
car's return needed, and L2 reached 21 A on a 16 A fuse when it resumed.

Core now judges a sample by when it first arrived on Core's clock. It
counts as in the reading only when it arrived evMeterDelay (1 s) before
the reading, and no more than one control interval before that. A sample
already there when Core began to watch the charger arrived at a time
Core does not know, so it never counts. The charger's stamp only tells
samples apart, so a charger clock behind Core's no longer matters.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): judge overages at the fuse rating, not fuse - 1 A

At margin 0 the car in s8-60-25 settles at the rating, as the owner's
rule says, and the rig's old 1 A hidden margin failed it: 271 s above
24 A against 67 s allowed, with no second over 25 A. siterig/full has the
same threshold in overage() (s9, s10, s11), the random invariants and
s15bat.

Port #1907's judge hunks: s3, s8, s9-s11, s15bat and the invariants now
count time over the fuse rating. TestS8JudgesAtTheFuse and #1907's
TestInvariantsJudgeAtTheFuse fail on the old judges.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* test(site): cap a stretch's events by the fuse heat; a car cut into export is FTW's own

Owner decisions of 28 Oct 2026 for the random judge:

- A car cut FTW sends that pushes export over the fuse is FTW's own, as
  a battery move toward export already was: after a step's meter delay
  and before the stretch, or while the stretch is over the fuse.
- What events add to a stretch (R2 growth) stops at the fuse's heat
  budget: once a phase's 60 s heat passes the fuse, Core's cut gets its
  lever's time and no further event extends the stretch. A window that
  opens after the allowance ran out, with the current under the fuse
  since, is a new step and its cap runs from it. This closes E3 (small
  real rises chaining a stretch's allowance).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-changeset PR intentionally exempt from the changeset requirement (dev tooling / non-shipping)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant