Repository navigation
Conversation
In latest queue update new subqueuettl driver was added. This driver needs per-subqueue statistics and adds a new `stats.extra` field for it. This addition also allows each driver to report meaningful operational metrics without extending the generic statistics implementation for every driver-specific use case.
Adds subqueuettl driver to the tests. This driver contains named subqueues stored in one space. It requires a subqueue name for put() and take(), so consumers can take tasks from a specific subqueue. Supports TTL, TTR, priority, and delay. In order to support this driver php functions have to support a subqueue name as an optional argument, also tests have to be updated providing this names.
Member
|
Hi @Col-Waltz, thank you for the PR! Could you please rebase it against master? I had to resurrect the disabled CI, fix a few CI issues, and drop old PHP versions. |
Member
|
After thinking about this more, I'm concerned that passing subqueue options to every method may make the API awkward. A subqueue handle could be a better DX: $subqueue = $queue->subqueue('emails');
$task = $subqueue->put($data);
$task = $subqueue->take(timeout: 2.0);
$subqueue->ack($task->getId());This also makes me wonder how we want to expose driver-specific behavior generally, as in #22. I'm not sure yet what the right API is, though. |
Member
|
Superseded by #30. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds subqueuettl driver to the tests: tarantool/queue@8b3c7c3. This driver contains
named subqueues stored in one space. It requires a subqueue
name for put() and take(), so consumers can take tasks from
a specific subqueue. Supports TTL, TTR, priority, and delay.
In order to support this driver php functions have to support
a subqueue name as an optional argument, also tests have to be
updated providing this names.