Repository navigation
feat(skills): add precompile design skills - #256
Merged
Merged
Conversation
Adds motivation-check, design-plan, design-council and adr-writer, which take a change motivation through independent design plans to a point-form ADR. Retires changelog-grill, changelog-gap-check and technical-document; adr-writer keeps the technical-document style references.
This was referenced Oct 23, 2026
Interface Coverage✅ All interface functions have test coverage. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
📊 Forge Coverage (
|
| File | Lines | Stmts | Branches | Funcs |
|---|---|---|---|---|
| 🟡 B20FactoryLib.sol | 97.70% | 98.00% | 100.00% | 95.00% |
| 🔴 test/lib/ForceFeeder.sol | 0.00% | 0.00% | 100.00% | 0.00% |
| 🔴 test/lib/PrecompileProbe.sol | 0.00% | 0.00% | 0.00% | 0.00% |
| 🟢 MockActivationRegistry.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockActivationRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20.sol | 100.00% | 99.68% | 100.00% | 100.00% |
| 🟢 MockB20Asset.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockB20Factory.sol | 98.96% | 99.10% | 100.00% | 100.00% |
| 🟢 MockB20Stablecoin.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockB20Storage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟢 MockBaseTime.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| 🟡 MockPolicyRegistry.sol | 100.00% | 99.58% | 97.78% | 100.00% |
| 🟢 MockPolicyRegistryStorage.sol | 100.00% | 100.00% | 100.00% | 100.00% |
| Total | 97.14% | 97.51% | 98.21% | 97.07% |
Full report: download artifact. To browse locally: make coverage (runs forge coverage + genhtml + opens the HTML report).
✅ Fork tests: 794 passed, 0 failed, 14 skippedThe completed Denim suite passed. Skipped tests were not validated. |
rayyan224
marked this pull request as ready for review
October 23, 2026 20:37
rayyan224
requested review from
amiecorso,
eric-ships and
ilikesymmetry
as code owners
October 23, 2026 20:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds four agent skills that take a precompile change from its motivation to a point-form ADR, and retires the skills they replace.
motivation-checkdesign-plandesign-counciladr-writerRemoved:
changelog-grill,changelog-gap-checkandtechnical-document.adr-writerkeeps the technical-document style references (Google technical writing, simplified technical English, point-form template).Notes
design-plan/references/bundles a plan template, a standalone linter (lint.pywithplan_inputs.py) and a short invariants file; the linter runs with plainpython3.global-invariants.mdand a comment inlint.py); they will be reworded before this leaves draft.How to verify